Bundle GCM under bin#512
Open
niik wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Johannes Schindelin <johannes.schindelin@gmx.de>
tidy-dev
approved these changes
Jun 11, 2024
dscho
reviewed
Jun 11, 2024
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
Does this need any change in how git is called, i.e. augmenting the PATH so that the executables in bin will be found?
Member
Author
Came back to merge this and looked into this. TL;DR, yes, we need to amend the PATH for macOS and Linux. On Windows we already add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with @dscho I now know that we shouldn't be sticking arbitrary stuff into
libexec/git-core, that's reserved for... ya know... git-core.So I've moved the git credential manager into the bin/ folder as per Johannes suggestion. We still drop Git LFS into
libexec/git-coreand I guess we should stop doing that as well but we've had LFS in there forever so let's start with just GCM and tackle LFS in a follow-up PR.